Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prettier to format *all* source files in client packages #3240

Merged
merged 6 commits into from
May 5, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented May 5, 2023

Closes #3208

Code Changes

  • Change "format" npm script to target all source files instead of select directories (e.g. prettier --write src __tests__/ --> prettier --write .)
  • Add prettier to sample-app and cypress-e2e packages
  • Use consistent .prettierignore and .prettierrc.json for all packages
  • Reformat all the things

Steps to Confirm

  • Run turbo format:ci from clients/ to quickly re-run formatting on the turbo-enabled packages (admin-ui, privacy-center, fides-js)
  • Run npm run format:ci from the non-turbo packages (cypress-e2e, sample-app)

Pre-Merge Checklist

Description Of Changes

I noticed that not all our source files were covered by prettier - this fixes that! 🎨

user: DATABASE_USER || 'postgres',
password: DATABASE_PASSWORD || 'postgres',
database: DATABASE_DB || 'postgres_example',
user: DATABASE_USER || "postgres",

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "postgres" is used as [user name](1).
password: DATABASE_PASSWORD || 'postgres',
database: DATABASE_DB || 'postgres_example',
user: DATABASE_USER || "postgres",
password: DATABASE_PASSWORD || "postgres",

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "postgres" is used as [password](1).
@cypress
Copy link

cypress bot commented May 5, 2023

Passing run #1789 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 26539b8 into d15487d...
Project: fides Commit: a6dfa5262f ℹ️
Status: Passed Duration: 00:59 💡
Started: May 5, 2023 8:51 PM Ended: May 5, 2023 8:52 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this update!

@NevilleS NevilleS merged commit b5b1649 into main May 5, 2023
@NevilleS NevilleS deleted the ns-run-prettier-3208 branch May 5, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prettier formatter isn't run on all source files (esp. Cypress tests!)
2 participants