Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fields in data use declaration form #3197

Merged
merged 13 commits into from
May 2, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented May 2, 2023

Closes #3177

Code Changes

  • Make the custom field location readonly when editing a custom field
  • Make name and data use readonly when editing a privacy declaration
  • Add custom fields to the privacy declaration form (in the portal only)

Steps to Confirm

  • Run fidesplus (nox -s "dev(slim)") backend and admin ui
  • Create some custom fields that have the system:data use location and create a system
  • Create a a few new privacy declarations with data in the custom fields. Make sure that the new PD maintains it's custom field data after the save
  • Edit all of the PDs and make sure the edited custom field data persists as expected
  • Make sure the name and data use fields should be read only when editing

Pre-Merge Checklist

Description Of Changes

example.mov

@cypress
Copy link

cypress bot commented May 2, 2023

Passing run #1692 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 3054d34 into a0c26a8...
Project: fides Commit: 9b30b89de9 ℹ️
Status: Passed Duration: 00:59 💡
Started: May 2, 2023 12:38 PM Ended: May 2, 2023 12:39 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review May 2, 2023 12:40
@TheAndrewJackson TheAndrewJackson self-assigned this May 2, 2023
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!! definitely some refactoring we can do but we can do a good chunk of it in #2976. I left some comments most of which can be TODOs—the only one that I'm slightly concerned about is that fidesKey thing on custom fields (I'm worried I removed it without seeing the consequence!)

@TheAndrewJackson TheAndrewJackson merged commit 3917575 into main May 2, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson_3177_custom_fields_in_pd_form branch May 2, 2023 14:26
TheAndrewJackson added a commit that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom fields to privacy declaration form
2 participants