-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom fields in data use declaration form #3197
Custom fields in data use declaration form #3197
Conversation
Passing run #1692 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!! definitely some refactoring we can do but we can do a good chunk of it in #2976. I left some comments most of which can be TODOs—the only one that I'm slightly concerned about is that fidesKey
thing on custom fields (I'm worried I removed it without seeing the consequence!)
clients/admin-ui/src/features/system/privacy-declarations/PrivacyDeclarationForm.tsx
Show resolved
Hide resolved
Co-authored-by: Allison King <[email protected]>
Closes #3177
Code Changes
Steps to Confirm
nox -s "dev(slim)"
) backend and admin uisystem:data use
location and create a systemPre-Merge Checklist
CHANGELOG.md
Description Of Changes
example.mov