Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom fields page #3089

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Apr 17, 2023

Closes #3077

Code Changes

  • Add custom fields page that's hidden behind a feature flag so it won't show up in prod builds. That flag cannot be modified.
  • Add new useGetAllCustomFieldDefinitionsQuery hook

Steps to Confirm

  • Run the admin ui, add a couple custom fields ( including taxonomy ones ), and make sure the custom field names show on the new page

Pre-Merge Checklist

Description Of Changes

This uses the same setup that privacy consent notices uses for feature flags so it will only show up in dev and test envs.

Screenshot 2023-04-17 at 15 46 35

@TheAndrewJackson TheAndrewJackson self-assigned this Apr 17, 2023
@cypress
Copy link

cypress bot commented Apr 17, 2023

Passing run #1379 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c11b36f into 34df89a...
Project: fides Commit: b9b7219d9a ℹ️
Status: Passed Duration: 00:35 💡
Started: Apr 17, 2023 8:03 PM Ended: Apr 17, 2023 8:04 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review April 17, 2023 20:06
@TheAndrewJackson
Copy link
Contributor Author

@allisonking I didn't update the changelog for this since it's temporary and there is no user facing change. If you think it still makes sense to update the changelog I can add an entry 👍

@allisonking
Copy link
Contributor

@allisonking I didn't update the changelog for this since it's temporary and there is no user facing change. If you think it still makes sense to update the changelog I can add an entry 👍

I've been adding changelog entries for the privacy notice stuff, but I don't have a strong opinion on the changelog. Maybe we should add it for this page just to be consistent?

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

clients/admin-ui/src/pages/management/custom-fields.tsx Outdated Show resolved Hide resolved
@TheAndrewJackson TheAndrewJackson merged commit cc222cb into main Apr 18, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson_3077_add_custom_fields_page branch April 18, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create custom field page scaffolding
2 participants