Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notification banner from home page #3088

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Apr 17, 2023

Closes #2844 (for real this time)

Code Changes

  • Removes the banner from the home page

Steps to Confirm

  • Log in as a viewer
  • You should no longer see the warning banner about scopes being migrated no matter which page you are on.

Pre-Merge Checklist

Description Of Changes

In #3055, I forgot the home page has a different Layout component than the rest of the app and also had a copy of the notification banner. This removes that banner as well.

The datamap UI also uses a different Layout component, but that one never had the banner so we are okay there 👍

@cypress
Copy link

cypress bot commented Apr 17, 2023

Passing run #1377 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 680f3ce into 34df89a...
Project: fides Commit: 9837eca8a7 ℹ️
Status: Passed Duration: 00:39 💡
Started: Apr 17, 2023 6:41 PM Ended: Apr 17, 2023 6:42 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking merged commit 4a864b2 into main Apr 17, 2023
@allisonking allisonking deleted the aking/2844/remove-banner-from-home branch April 17, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove access control notification banner
2 participants