Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish git-tag-specific docker images #3050

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Apr 12, 2023

Partially closes #2919

Code Changes

  • include a push session arg that can push images corresponding to a git tag, if one exists on the current commit (nox -s "push(git-tag)")
  • update GH actions to invoke this push session on any tags that are not prod tags (prod tags already publish a nice, clean, versioned docker image via the push(prod) session, so it's not needed and we don't want to duplicate)
    • this new nox session is a no-op if it finds no explicit git tag on the current commit, so we are OK to invoke it liberally, and it will weed out any commits where there's no tag, e.g. a "normal" commit to main. the dev tagged image will continue to be published on commits to main.
    • as it stands now in the PR, feature and release branch tags will also publish the :dev image. this may or may not be desirable - the main outstanding question i've got for this PR

Steps to Confirm

  • i'll use this as a chance to actually push a tag to this branch and see if it goes thru to publish an image on dockerhub!
    • this was successful: this was published by this

Pre-Merge Checklist

Description Of Changes

This should be a helpful piece for both feature-branch deployments and release-branch (rc) deployments

@cypress
Copy link

cypress bot commented Apr 12, 2023

Passing run #1315 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 04f974f into d26ed89...
Project: fides Commit: f91249350f ℹ️
Status: Passed Duration: 00:37 💡
Started: Apr 12, 2023 7:58 PM Ended: Apr 12, 2023 7:59 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (65005e5) 87.41% compared to head (73e458a) 87.41%.

❗ Current head 73e458a differs from pull request most recent head 04f974f. Consider uploading reports for the commit 04f974f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3050   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files         306      306           
  Lines       17534    17540    +6     
  Branches     2255     2255           
=======================================
+ Hits        15327    15333    +6     
  Misses       1793     1793           
  Partials      414      414           

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamsachs adamsachs marked this pull request as ready for review April 12, 2023 18:17
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my nits are all just naming things.

@adamsachs adamsachs force-pushed the tagging-building-for-release-testing branch from c8a2a66 to 04f974f Compare April 12, 2023 19:42
@adamsachs adamsachs merged commit 6a98b3d into main Apr 12, 2023
@adamsachs adamsachs deleted the tagging-building-for-release-testing branch April 12, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature branch builds - CI automation
2 participants