-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish git-tag-specific docker images #3050
Conversation
Passing run #1315 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3050 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 306 306
Lines 17534 17540 +6
Branches 2255 2255
=======================================
+ Hits 15327 15333 +6
Misses 1793 1793
Partials 414 414 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my nits are all just naming things.
c8a2a66
to
04f974f
Compare
Partially closes #2919
Code Changes
push
session arg that can push images corresponding to a git tag, if one exists on the current commit (nox -s "push(git-tag)"
)push
session on any tags that are not prod tags (prod tags already publish a nice, clean, versioned docker image via thepush(prod)
session, so it's not needed and we don't want to duplicate)main
. thedev
tagged image will continue to be published on commits tomain
.:dev
image. this may or may not be desirable - the main outstanding question i've got for this PRSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This should be a helpful piece for both feature-branch deployments and release-branch (rc) deployments