Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update datamap table export #3038

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Update datamap table export #3038

merged 7 commits into from
Apr 12, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Apr 11, 2023 •
edited
Loading

Closes fidesplus#763

Code Changes

  • Updated the datamap export to what's shown in the table. This was done by using the data from the tableInstance instead of calling to the backend.
  • Remove all of the radio button options from the export

Steps to Confirm

  • Run admin ui and fidesplus backend. Run a dataflow scan
  • Add some privacy declarations that have multiple categories that get grouped together
  • Export the csv and excel files. They should match what's in the table

Pre-Merge Checklist

Description Of Changes

Screenshot 2023-04-11 at 16 53 03

@TheAndrewJackson TheAndrewJackson changed the title Ajackson fidesplus 763 update export Update datamap table export Apr 11, 2023
@cypress
Copy link

cypress bot commented Apr 11, 2023 •
edited
Loading

Passing run #1283 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 93583dd into 2aa7858...
Project: fides Commit: f795d3d376 ℹ️
Status: Passed Duration: 00:41 💡
Started: Apr 11, 2023 9:04 PM Ended: Apr 11, 2023 9:04 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review April 11, 2023 21:09
@TheAndrewJackson TheAndrewJackson self-assigned this Apr 11, 2023
allisonking
allisonking approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works great! and removes so much code too, nice work 😎

@TheAndrewJackson TheAndrewJackson merged commit 65005e5 into main Apr 12, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson_fidesplus_763_update_export branch April 12, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees

@TheAndrewJackson TheAndrewJackson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheAndrewJackson @allisonking