Privacy notice empty state

[allisonking]

Closes https://github.com/ethyca/fidesplus/issues/738

Code Changes

• Add chrome around the page (breadcrumbs, header) which I missed in the initial page scaffolding ticket
• Add empty state
• Cypress test

Steps to Confirm

• Start up fidesplus
• Navigate to Privacy requests > Privacy notices
• You should see the empty state

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

Description Of Changes

Note: the "See data uses" button goes to the /systems route at the moment, though this still appears to be in discussion. There is also no link to the "Consent guide" mentioned in the copy right now.

[cypress]

Passing run #1305 ↗︎

0	3	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge 8b91d63 into 65005e5...
Project: fides	Commit: 95bd45832b ℹ️
Status: Passed	Duration: 00:56 💡
Started: Apr 12, 2023 3:23 PM	Ended: Apr 12, 2023 3:24 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[allisonking]

It just occurred to me that this copy might not be right for someone with the Viewer role who can't actually set up data uses. Should we render something else for Viewers/Viewers+Approvers? @mfbrown

So overall, 3 questions for you:

1. Where should the "set up data uses" button go?
2. What should "Consent Guide" link to?
3. Should we render different copy for Viewers/Viewers+Approvers?

[mfbrown]

It just occurred to me that this copy might not be right for someone with the Viewer role who can't actually set up data uses. Should we render something else for Viewers/Viewers+Approvers? @mfbrown

So overall, 3 questions for you:

1. Where should the "set up data uses" button go?
2. What should "Consent Guide" link to?
3. Should we render different copy for Viewers/Viewers+Approvers?

1. In order for a notice to appear, there must be systems with data uses that match the notices, so the natural place for a user to go right now is the /system route. I don't think this is an ideal solution, because it still requires an additional step from the user of selecting a system and knowing what data use to apply, but in the absence of additional guidance capabilities, let's go to this screen for now.
2. Let's axe that last sentence for now until we publish documentation that targets this area. I'll create a follow up issue for that.
3. Do we have any other examples yet in the app where we've changed copy for viewers and not just visibility or active/disabled state?

[allisonking]

Thanks @mfbrown , those sound good to me!

Do we have any other examples yet in the app where we've changed copy for viewers and not just visibility or active/disabled state?

We render some copy when a contributor shows up on an owner's permission page saying they can't change that user's permissions. But yeah for the most part we just control visibility / disabled state

[TheAndrewJackson]

🧨