-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2213 custom connector front end #2997
Conversation
Passing run #1224 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
==========================================
- Coverage 86.90% 86.89% -0.01%
==========================================
Files 303 303
Lines 17298 17274 -24
Branches 2223 2215 -8
==========================================
- Hits 15033 15011 -22
+ Misses 1849 1848 -1
+ Partials 416 415 -1
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome job @galvana !! I've got mostly small comments but nothing blocking.
I did notice I could upload the planet express zip twice and I got a success message. Planet express still only shows up once though, so maybe that's okay?
clients/admin-ui/src/features/connector-templates/ConnectorTemplateUploadModal.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/datastore-connections/add-connection/ChooseConnection.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/datastore-connections/add-connection/ChooseConnection.tsx
Show resolved
Hide resolved
clients/admin-ui/src/features/connector-templates/connector-template.slice.ts
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/datastore-connections/add-connection/ChooseConnection.tsx
Outdated
Show resolved
Hide resolved
Thanks for the review @allisonking! I've made the requested changes. Also, the upload is working as expected, since it's the same template it just updates the existing one 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!! 💥
Closes #2213 #2214
Code Changes
react-dropzone
dependencyConnectorTemplateUploadModal
connector-template.slice.ts
to make the call to/connector_template/register
Upload template
button in the choose connection screen (only accessible to users with theCONNECTOR_REGISTER_TEMPLATE
scope)Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Added a button to the Choose connection screen which opens a modal to upload a connector template. This button only shows up for users with the
CONNECTOR_REGISTER_TEMPLATE
scope.