Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2213 custom connector front end #2997

Merged
merged 24 commits into from
Apr 10, 2023
Merged

2213 custom connector front end #2997

merged 24 commits into from
Apr 10, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Apr 5, 2023

Closes #2213 #2214

Code Changes

  • Added react-dropzone dependency
  • Added ConnectorTemplateUploadModal
  • Added connector-template.slice.ts to make the call to /connector_template/register
  • Added Upload template button in the choose connection screen (only accessible to users with the CONNECTOR_REGISTER_TEMPLATE scope)

Steps to Confirm

Pre-Merge Checklist

Description Of Changes

Added a button to the Choose connection screen which opens a modal to upload a connector template. This button only shows up for users with the CONNECTOR_REGISTER_TEMPLATE scope.

@galvana galvana requested a review from allisonking April 5, 2023 21:41
@galvana galvana marked this pull request as ready for review April 5, 2023 21:41
@cypress
Copy link

cypress bot commented Apr 5, 2023

Passing run #1224 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 09e213a into 241f6e0...
Project: fides Commit: c515871e6f ℹ️
Status: Passed Duration: 00:39 💡
Started: Apr 7, 2023 6:18 PM Ended: Apr 7, 2023 6:18 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (241f6e0) 86.90% compared to head (1619d95) 86.89%.

❗ Current head 1619d95 differs from pull request most recent head 09e213a. Consider uploading reports for the commit 09e213a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
- Coverage   86.90%   86.89%   -0.01%     
==========================================
  Files         303      303              
  Lines       17298    17274      -24     
  Branches     2223     2215       -8     
==========================================
- Hits        15033    15011      -22     
+ Misses       1849     1848       -1     
+ Partials      416      415       -1     
Impacted Files Coverage Δ
...vice/connectors/saas/connector_registry_service.py 94.68% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job @galvana !! I've got mostly small comments but nothing blocking.

I did notice I could upload the planet express zip twice and I got a success message. Planet express still only shows up once though, so maybe that's okay?

@galvana
Copy link
Contributor Author

galvana commented Apr 7, 2023

Thanks for the review @allisonking! I've made the requested changes. Also, the upload is working as expected, since it's the same template it just updates the existing one 👍

@galvana galvana requested a review from allisonking April 7, 2023 16:49
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! 💥

@galvana galvana merged commit dd3fc1b into main Apr 10, 2023
@galvana galvana deleted the 2213-custom-connector-front-end branch April 10, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functionality to upload connector templates
2 participants