consent/access/erasure query param filters on connection type endpoint

[adamsachs]

Partially closes #2834

Code Changes

• add query params to connection type endpoint that allow for filtering of connection types based on the types of request they support (i.e. consent, access, erasure)

Steps to Confirm

• list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

Description Of Changes

Write some things here about the changes and any potential caveats

[cypress]

Passing run #1209 ↗︎

0

3

0

0

0

Details:

Merge ce72b98 into 4012567...
Project: fides	Commit: f3d0bdc935 ℹ️
Status: Passed	Duration: 00:54 💡
Started: Apr 7, 2023 1:51 PM	Ended: Apr 7, 2023 1:52 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch coverage: 92.59% and project coverage change: -0.01 ⚠️

Comparison is base (e5b39e2) 86.91% compared to head (ce72b98) 86.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2996      +/-   ##
==========================================
- Coverage   86.91%   86.90%   -0.01%     
==========================================
  Files         303      303              
  Lines       17274    17298      +24     
  Branches     2215     2223       +8     
==========================================
+ Hits        15013    15033      +20     
- Misses       1847     1849       +2     
- Partials      414      416       +2     

Impacted Files	Coverage Δ
src/fides/api/ops/util/connection_type.py	88.33% <87.50%> (-1.03%)	⬇️
.../ops/api/v1/endpoints/connection_type_endpoints.py	100.00% <100.00%> (ø)
src/fides/api/ops/models/policy.py	86.86% <100.00%> (+0.04%)	⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pattisdr]

this is going in a good direction Adam! The logic on this endpoint is already a little complicated to follow given all the historical differences between db and saas connectors, and new email connectors, etc. I like your saas_request_type_filter method too, nice that we can tell programmatically what they support. I forgot about data protection requests, that was awhile ago!

[pattisdr]

Whoops wrong PR, starting with the review on this one first

[pattisdr]

Great tests here @adamsachs. The logic is a little hard to follow in places but that is the fault of the existing endpoint and historical differences between db/saas/email connectors. I think this looks good as-is, we should just pay attention as new connectors go in how we might need to adjust this.

great making the saas connection logic as programmatic as possible.

[adamsachs]

@pattisdr i think this is ready to go now! there's a silly codecov miss, i left a comment around it. curious to get your thoughts just as a matter of curiosity, but it's trivial, don't want to spend more than a few seconds on it :)

[pattisdr]

🏆