endpoint to retrieve privacy notices by data use

[adamsachs]

Partially closes #2834 (1 of 2 required endpoints)

Code Changes

• new GET /api/v1/privacy-notice-by-data-use endpoint that returns a map of DataUses with their corresponding PrivacyNotices
  • Only DataUses that are associated with a System are included in the map.
  • DataUses that do not have any PrivacyNotice associated with them are included
    in the map, with empty lists.

Steps to Confirm

• add some Systems with privacy declarations (easiest to do thru the UI)
• add some PrivacyNotices that have DataUses that overlap with the privacy declarations of your Systems (must be manual POST /api/v1/privacy-notice API calls for now)
• invoke the GET /api/v1/privacy-notice-by-data-use endpoint, and ensure the result looks as expected

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

[cypress]

Passing run #1231 ↗︎

0

3

0

0

0

Details:

Merge 99cc638 into b62d238...
Project: fides	Commit: d7aff7c5c1 ℹ️
Status: Passed	Duration: 00:48 💡
Started: Apr 7, 2023 9:31 PM	Ended: Apr 7, 2023 9:32 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch coverage: 97.67% and project coverage change: +0.01 🎉

Comparison is base (b62d238) 86.90% compared to head (4d42e5b) 86.92%.

❗ Current head 4d42e5b differs from pull request most recent head 99cc638. Consider uploading reports for the commit 99cc638 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2956      +/-   ##
==========================================
+ Coverage   86.90%   86.92%   +0.01%     
==========================================
  Files         303      303              
  Lines       17298    17322      +24     
  Branches     2223     2230       +7     
==========================================
+ Hits        15033    15057      +24     
  Misses       1849     1849              
  Partials      416      416              

Impacted Files	Coverage Δ
src/fides/api/ctl/sql_models.py	98.15% <90.90%> (+0.06%)	⬆️
...i/ops/api/v1/endpoints/privacy_notice_endpoints.py	100.00% <100.00%> (ø)
src/fides/api/ops/api/v1/urn_registry.py	100.00% <100.00%> (ø)
src/fides/api/ops/models/privacy_notice.py	100.00% <100.00%> (ø)
src/fides/api/ops/schemas/privacy_notice.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pattisdr]

This is great, Adam. Endpoint is very clear and well documented. My main question is around data use hierarchies -

[adamsachs]

OK @pattisdr i think this one is also just about good to go, but no big rush on it!

there's a codecov miss i'm not too concerned about, although i'll try to circle back to it to provide some targeted tests on the System.get_system_data_uses() classmethod if i've got time!

[pattisdr]

I had a slightly different interpretation here, wanted to see what you thought -

[adamsachs]

@pattisdr i think this is ready for another look when you get a chance. i've taken your suggestion on the behavior for hierarchical overlaps - let me know if that looks correct to you!

(codecov still "fails" but doesn't even give me a concrete miss! 😒 )

[pattisdr]

looking now!

[pattisdr]

looks solid @adamsachs great code comments as usual.