-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update frontend npm packages (admin-ui, privacy-center, cypress-e2e) #2921
Conversation
Passing run #1042 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2921 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 299 299
Lines 16837 16837
Branches 2148 2148
=======================================
Hits 14587 14587
Misses 1841 1841
Partials 409 409 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
That's a bit odd, because that definitely runs as part of the CI checks. Let me know what you find |
I was able to logout with the test build. I think it's probably just a flaky test. If you're not seeing/rarely seeing that failure locally I'm comfortable with merging this |
OK thanks- drop a review here, I'm re-running |
(Side note, and maybe related... one dependency I didn't update to latest was |
Code Changes
npm update
to "safely" upgrade based on semver, etcnpm-check-updates
utility to selectively upgrade dependencies to latest versions, where it felt reasonablenpx depcheck
to find unused dependencies andnpm uninstall
themSteps to Confirm
npm test
,npm run cy:run
)nox -s "fides_env(test)"
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
It felt like some spring cleaning was in order, especially as we look towards some major new features in the Admin UI. This is a sweeping update of our frontend dependencies including some major version upgrades to packages like
react-redux
,eslint
, etc.The packages I avoided here that require more careful consideration are
react
,next
,chakra-ui
, andtypescript
. Some of these will likely need code migrations or breaking changes, so I didn't attempt those upgrades.