-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth to the masking endpoints #2909
Conversation
…ake sense when used more broadly
Passing run #1011 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
…ependency to masking endpoints
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 299 299
Lines 16832 16837 +5
Branches 2148 2148
=======================================
+ Hits 14582 14587 +5
Misses 1841 1841
Partials 409 409
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my end. No concerns, but others should probably give the explicit approval :)
Closes https://github.com/ethyca/security-issues/issues/13
Code Changes
verify_oauth_client_cli
->verify_oauth_client_prod
MASKING
scopes forMASKING:EXEC
andMASKING:READ
MASKING
scopes to theVIEWER
role (they are low-risk and without side-effects)Security
dependency to themasking
endpointsSteps to Confirm
prod
security environment, try to hit themasking
endpoints, expect a 401Pre-Merge Checklist
CHANGELOG.md
Relevant Follow-Up Issues CreatedFor API changes, the Postman collection has been updatedDescription Of Changes
This is PR adds authentication to the
masking
endpoints as well as accompanyingscopes
. Note that it is only authenticated inprod
mode to make it a non-breaking change.