Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Version to Fides Core Version #2899

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Conversation

nicolas-ethyca
Copy link
Contributor

This allows end users on FidesPlus to see the Fides Core it is using and not to be confused with Fides Plus.

Closes #TBD

Code Changes

  • Changes the text Version: to Fides Core Version:

Steps to Confirm

  • Sign in and go to About page

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me! Less confusion the better

@cypress
Copy link

cypress bot commented Mar 22, 2023

Passing run #932 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a27ef88 into 627340c...
Project: fides Commit: 316c16a9de ℹ️
Status: Passed Duration: 00:35 💡
Started: Mar 22, 2023 7:00 PM Ended: Mar 22, 2023 7:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging in a sec

CHANGELOG.md Outdated Show resolved Hide resolved
@NevilleS NevilleS merged commit 57629ea into main Mar 22, 2023
@NevilleS NevilleS deleted the feature/fidecoreversion branch March 22, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants