-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a notification banner to show up on login #2842
Conversation
Passing run #834 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2842 +/- ##
==========================================
+ Coverage 86.73% 86.74% +0.01%
==========================================
Files 295 295
Lines 16753 16753
Branches 2145 2145
==========================================
+ Hits 14531 14533 +2
+ Misses 1819 1818 -1
+ Partials 403 402 -1 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a couple little nits
Just pushed one more change to make the banner only viewable to viewers. will update the steps to confirm |
Closes https://github.com/ethyca/fidesplus/issues/676
Code Changes
HomeLayout
similar to https://github.com/ethyca/fides/pull/2812/filesSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
I wasn't sure if we wanted to add a check against the fides version here? Or how we determine when we will remove this banner.
Screen.Recording.2023-03-15.at.12.52.11.PM.mov