-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Scopes and Add Viewer Role #2821
Conversation
Passing run #835 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2821 +/- ##
=======================================
Coverage 86.73% 86.73%
=======================================
Files 295 295
Lines 16753 16753
Branches 2145 2145
=======================================
Hits 14531 14531
Misses 1819 1819
Partials 403 403
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the scopes/roles migration lgtm! don't know much about the other stuff though :)
Thank you @allisonking! I'll see if I can get @adamsachs to take a look at the other piece. I'll hold off on merging until your piece is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, thanks a lot for the cleanup/follow-up work here! 🧹
src/fides/api/ctl/migrations/versions/50180bbbb959_automigrate_viewer_role.py
Show resolved
Hide resolved
Thanks @adamsachs 🏆 |
# Conflicts: # CHANGELOG.md
Updated with main for CHANGELOG conflict |
Closes #2776
❗ Locked to the same release as #2739
Code Changes
contributor
scopes - Allow UI-created users to use system config UI #2791 (comment)viewer
role, removes their scopes from their permissions and client tablemessagingconfig_service_type_key
unique index, leftovers from 179f2bb623ae_update_table_for_twilio.py. From Adam: i'm assuming that index got deleted in my migration along with dropping the column it refers to, i.e. with op.drop_column("messagingconfig", "service_type_old") - since earlier in the migration i had:op.alter_column( "messagingconfig", "service_type", new_column_name="service_type_old" )
and so now the new migration is adding it back in to keep things in sync
prod
setting - this extends this to when we run fides test envSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This is an automated data migration to transition to the new "roles".
Sets all user scopes to an empty list and gives all users a
viewer
role. Someone will need to login as a root user and assign roles. Intentionally nothing preventing users from adding scopes to their users via the API yet.A followup in a future sprint will get rid of
fidesuserpermission.scopes
entirely #2696