Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbounce Connector #2697

Merged
merged 19 commits into from
Apr 26, 2023
Merged

Unbounce Connector #2697

merged 19 commits into from
Apr 26, 2023

Conversation

tmuralikrishnan
Copy link
Contributor

@tmuralikrishnan tmuralikrishnan commented Feb 24, 2023

Closes #1346

Code Changes

NEW SaaS Connector Unbounce for access

Steps to Confirm

  • Add/configure the Unbounce connector in UI
  • Verify Unbounce config and icon UI looks good
  • Add leads data using Unbounce API
  • Create an Access DSR with the new Unbounce customer email
  • Verify email sent by fides with customer data is correct

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

SaaS Connector Checklist

  • Spec doc link
  • Vault Creds
  • Postman Collection
  • SaaS Config And Dataset
  • Access Tests Passing
  • Icon

@cypress
Copy link

cypress bot commented Feb 24, 2023

Passing run #1573 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 2163acf into c350a5e...
Project: fides Commit: ece90d10a0 ℹ️
Status: Passed Duration: 00:53 💡
Started: Apr 25, 2023 9:18 PM Ended: Apr 25, 2023 9:18 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (c350a5e) 87.51% compared to head (2163acf) 87.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2697      +/-   ##
==========================================
- Coverage   87.51%   87.51%   -0.01%     
==========================================
  Files         309      309              
  Lines       18010    18010              
  Branches     2341     2341              
==========================================
- Hits        15762    15761       -1     
- Misses       1822     1823       +1     
  Partials      426      426              

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmuralikrishnan
Copy link
Contributor Author

image

@tmuralikrishnan
Copy link
Contributor Author

image

@Kelsey-Ethyca Kelsey-Ethyca changed the title unbounce access request test Unbounce Connector Mar 13, 2023
@galvana galvana self-requested a review April 18, 2023 16:03
@galvana galvana merged commit ea5975e into main Apr 26, 2023
@galvana galvana deleted the unbounce-access-muralikrishnan branch April 26, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unbounce
5 participants