-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-Generate config documentation #2694
Conversation
Passing run #524 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
==========================================
+ Coverage 86.51% 86.58% +0.06%
==========================================
Files 289 290 +1
Lines 16127 16210 +83
Branches 2044 2059 +15
==========================================
+ Hits 13952 14035 +83
- Misses 1791 1792 +1
+ Partials 384 383 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…nd reorganize code locations
…fig docs from the new site back into this one
I'm fixing up the test coverage but this is good for people to start reviewing 🙏 |
docstrings from sean:
|
…credentials help links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delays in reviewing! Spent some time working through how the opt out functionality is changing since it has snuck up on us a couple of times in the past. Added one question and a couple nits but everything checked out great for me 🙌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work here. I love this change! This will help a lot with understanding how each option works in fides.toml
. I just left a few small not blocking nits
@adamsachs I saw you made some docs updates to the config, could you help me mirror them here if they aren't already in |
Co-authored-by: Steve Murphy <[email protected]>
…m/ethyca/fides into ThomasLaPiana-autogen-config-docs
I'm being bad and merging despite not having 100% patch coverage, but overall code cov is up and the part missing coverage is something we weren't testing before either (not an excuse, but makes it feel better?) The missing tests are around the analytics consent messaging, which require user inputs and therefore no easy way to test |
@ThomasLaPiana i think we're good? this PR https://github.com/ethyca/fidesdocs/pull/52 had my changes to the docs, but i don't think what you've done here interacts with that at all? in any case, those config properties are properly annotated as pydantic let me know if i'm missing something though. |
We good we good! My bad, thanks for replying 😄 |
Closes #2627
Code Changes
toml
that includes helpful metadatagenerate_docs
Nox session, included as part of the backend checksfides init
check_and_update_analytics_config
function so that it doesn't check for anone
value (since the default is nowtrue
, this is pointless)fides init
orfides deploy up
init
anddeploy up
Steps to Confirm
nox -s docs_serve
and visit theconfiguration
page. Confirm the toml snippet is rendering properlyfides init
, verify that the new config file is producedfides view config
to verify the updates)generat_docs
nox session and CI checkPre-Merge Checklist
CHANGELOG.md
Description Of Changes
This PR fundamentally changes how our "default" config file is produced and therefore also fundamentally changes
fides init
.The new config file is built from the source code directly and includes with it all of the useful metadata we have as part of Pydantic and Pydantic
Field
objects. An important piece is that the generated config file is still validtoml
and will be what the user interacts with directly when configuring their instance! CI Checks will fail if a config value doesn't have a description, the description is blank, or it is "TODO"Additionally, the new configuration file reference is built and hosted on the docs site, as a reference to users on older versions or who have been upgrading and used a past version of
fides init
. The new configuration docs will be cross-linked from the new docs site.Note that as part of this change, how/when we collect user consent has changed. It is less intrusive now. It defaults to opt-out (no dark patterns here) but gives the option to opt-in upon
fides init
and will update the config file directly.Note: Given the lack of a
None
type intoml
,Optional
or empty values are no longer valid in the configuration file! If needed, you can set a default value and do a truthiness check. i.e."" == False
, as does[] == False
, so we need to leverage that type of check instead.Preview of new autogenerated config