527 custom field library tab

[chriscalhoun1974]

Closes #527 #2659

Code Changes

• Created ChooseFromLibrary component
• Deleted CustomFieldSelector component
• Updated CreateCustomFields, CreateCustomLists, CustomFieldsModal, and CustomInput custom fields components
• Updates to CustomTextInput, CustomSelect, CustomCreatableSelect, and CustomTextArea components which format the error message to be displayed below the given input component

Steps to Confirm

1. Run the make server command from a FidesPlus Terminal prompt
2. Run npm i command from Fides Admin UI Terminal prompt
3. Run npm run dev command from Fides Admin UI Terminal prompt
4. Open a browser tab and navigate to http://localhost:3000
5. Click the Management top nav menu item
6. Click an edited resource such as Data Category, Data Use, or Data Subject
7. Click the plus icon with the Add a custom field label
8. Click the Create custom lists tab and enter the form data. Click the Save to library button.
9. Click the Create custom fields tab and enter the form data. Click the Save button.
10. Exit the Add custom field modal
11. Click the plus icon with the Add a custom field label
12. Click the Choose from library tab. Toggle the active status to off. Click the Save button.
13. Verify that the custom field that you just marked inactive is not listed in Custom fields section of the edited resource.

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md

Screen Shots

[cypress]

Passing run #654 ↗︎

0

3

0

0

0

Details:

Merge 7ef8ba3 into 1c39399...
Project: fides	Commit: 10478fe6c3 ℹ️
Status: Passed	Duration: 00:38 💡
Started: Mar 6, 2023 7:37 PM	Ended: Mar 6, 2023 7:38 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (e07f896) 86.66% compared to head (7ef8ba3) 86.66%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2693   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files         291      291           
  Lines       16458    16458           
  Branches     2114     2114           
=======================================
  Hits        14264    14264           
  Misses       1795     1795           
  Partials      399      399           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mfbrown]

@chriscalhoun1974 attached a recording of one issue I found. When you re-enable a custom field that has an existing value, the value does not show unless you refresh the whole page.

https://www.loom.com/share/96e15f950c114dda87094ec9ab2f569f

[chriscalhoun1974]

@mfbrown Loom issue has been resolved now.

[mfbrown]

@mfbrown Loom issue has been resolved now.

@chriscalhoun1974 now the values seem to disappear when you click "Save"

https://www.loom.com/share/f96c3e1cec6a4d3eb24d3d1ecf069d3c

[chriscalhoun1974]

@mfbrown Form value selections disappearing after you click the Save button has been resolved now.

[mfbrown]

The fix for the previous issue seems to have re-introduced the issue where re-enabled custom fields don't show their value.

https://www.loom.com/share/e104aebfb3e04221b8a1fd2bf1d3a087

cc: @Kelsey-Ethyca

[mfbrown]

This PR does fix #2693 !

[mfbrown]

LGTM - will create a follow up issue to address the inconsistencies with re-showing fields that have values.