Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from pickle to json for cache #2643

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Switch from pickle to json for cache #2643

merged 6 commits into from
Feb 22, 2023

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Feb 17, 2023

Closes #2633

Code Changes

  • Replaces pickle with json encoding for cache.
  • Handles cases where old cache pickle values are still present.

Steps to Confirm

  • Create a privacy request
  • Approve and run the privacy request
  • Create a failed privacy request cached in the old pickle format, run a new privacy request and verify there are no 500 server errors.
  • Test any other areas that caches data, the more you can think of the better here.

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@cypress
Copy link

cypress bot commented Feb 17, 2023

Passing run #262 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 95cc9eb into 871ccf6...
Project: fides Commit: 086e0b9897 ℹ️
Status: Passed Duration: 00:38 💡
Started: Feb 21, 2023 10:01 PM Ended: Feb 21, 2023 10:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 86.22% // Head: 86.27% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (95cc9eb) compared to base (ea5cf1d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2643      +/-   ##
==========================================
+ Coverage   86.22%   86.27%   +0.04%     
==========================================
  Files         289      289              
  Lines       15780    15842      +62     
  Branches     1985     1998      +13     
==========================================
+ Hits        13607    13668      +61     
- Misses       1785     1786       +1     
  Partials      388      388              
Impacted Files Coverage Δ
src/fides/api/ops/models/privacy_request.py 95.94% <100.00%> (+0.06%) ⬆️
src/fides/api/ops/util/cache.py 93.96% <100.00%> (+3.17%) ⬆️
src/fides/cli/commands/util.py 57.89% <0.00%> (-0.78%) ⬇️
src/fides/cli/__init__.py 92.00% <0.00%> (-0.73%) ⬇️
src/fides/core/api.py 82.85% <0.00%> (ø)
src/fides/core/user.py 100.00% <0.00%> (ø)
src/fides/cli/commands/db.py 81.48% <0.00%> (ø)
src/fides/core/config/user_settings.py 100.00% <0.00%> (ø)
src/fides/core/utils.py 86.15% <0.00%> (+5.30%) ⬆️
src/fides/core/deploy.py 38.58% <0.00%> (+5.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanders41 sanders41 marked this pull request as ready for review February 17, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy Request Manager page fails to load previously errored requests
2 participants