-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack creatable multiselect #2620
Conversation
Passing run #211 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportBase: 86.23% // Head: 86.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
- Coverage 86.23% 86.22% -0.01%
==========================================
Files 289 289
Lines 15784 15784
Branches 1985 1985
==========================================
- Hits 13611 13610 -1
Misses 1785 1785
- Partials 388 389 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Failing test is unrelated to this PR |
Closes #2603
This is pretty much a continuation of https://github.com/ethyca/fides/pull/2542/files
Code Changes
CreatableSelect
component out intoCreatableSelectInput
which can be used for both single and multiinline
andstacked
variant forCustomCreatableSelect
(which is now a combo of what used to beCustomCreatableSingleSelect
andCustomCreatableMultiSelect
Steps to Confirm
DescribeSystemStep.tsx
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Stacked vs inline multi creatable select
Screen.Recording.2023-02-16.at.10.10.23.AM.mov
Stacked vs inline single creatable select
Screen.Recording.2023-02-16.at.10.11.21.AM.mov
Nothing uses the single creatable select right now, though it might be useful for something like a search bar with suggestions.
There is a
disableMenu
prop because of #772 (comment). I think it can be weird at times to not have the menu, but it works okay with the inputs we have so far because we really don't populate possible options yet