Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack creatable multiselect #2620

Merged
merged 6 commits into from
Feb 21, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Feb 15, 2023

Closes #2603

This is pretty much a continuation of https://github.com/ethyca/fides/pull/2542/files

Code Changes

  • Refactors the CreatableSelect component out into CreatableSelectInput which can be used for both single and multi
  • Allows an inline and stacked variant for CustomCreatableSelect (which is now a combo of what used to be CustomCreatableSingleSelect and CustomCreatableMultiSelect

Steps to Confirm

  • Nothing uses these stacked components yet, but you can try them out in i.e. DescribeSystemStep.tsx

Pre-Merge Checklist

Description Of Changes

Stacked vs inline multi creatable select

Screen.Recording.2023-02-16.at.10.10.23.AM.mov

Stacked vs inline single creatable select

Screen.Recording.2023-02-16.at.10.11.21.AM.mov

Nothing uses the single creatable select right now, though it might be useful for something like a search bar with suggestions.

There is a disableMenu prop because of #772 (comment). I think it can be weird at times to not have the menu, but it works okay with the inputs we have so far because we really don't populate possible options yet

@cypress
Copy link

cypress bot commented Feb 15, 2023

Passing run #211 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 613f367 into ac89777...
Project: fides Commit: 9a47485a83 ℹ️
Status: Passed Duration: 00:37 💡
Started: Feb 17, 2023 7:41 PM Ended: Feb 17, 2023 7:41 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 86.23% // Head: 86.22% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (613f367) compared to base (69ecb30).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
- Coverage   86.23%   86.22%   -0.01%     
==========================================
  Files         289      289              
  Lines       15784    15784              
  Branches     1985     1985              
==========================================
- Hits        13611    13610       -1     
  Misses       1785     1785              
- Partials      388      389       +1     
Impacted Files Coverage Δ
src/fides/api/ops/task/graph_task.py 94.15% <0.00%> (-0.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allisonking allisonking marked this pull request as ready for review February 16, 2023 16:04
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@allisonking
Copy link
Contributor Author

Failing test is unrelated to this PR

@allisonking allisonking merged commit 871ccf6 into main Feb 21, 2023
@allisonking allisonking deleted the aking/2603/stack-creatable-multiselect branch February 21, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stacked variant for multiselect forms
2 participants