Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Firebase Auth to delete user #2602

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Updating Firebase Auth to delete user #2602

merged 4 commits into from
Feb 15, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Feb 15, 2023 •
edited
Loading

Closes #2601

Code Changes

  • Updating config to use firebase_auth_user_delete instead of firebase_auth_user_update

Steps to Confirm

  • Ran integration tests

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@galvana galvana linked an issue Feb 15, 2023 that may be closed by this pull request
Update Firebase Auth to delete user instead of updating it #2601
Closed
@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Feb 15, 2023
@cypress
Copy link

cypress bot commented Feb 15, 2023 •
edited
Loading

Passing run #119 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 6aa01e8 into 5f533b2...
Project: fides Commit: 8b08cc21b7 ℹ️
Status: Passed Duration: 00:37 💡
Started: Feb 15, 2023 6:35 PM Ended: Feb 15, 2023 6:35 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Feb 15, 2023 •
edited
Loading

Codecov Report

Base: 85.91% // Head: 85.91% // No change to project coverage 👍

Coverage data is based on head (6aa01e8) compared to base (5f533b2).
Patch has no changes to coverable lines.

❗ Current head 6aa01e8 differs from pull request most recent head f6d935b. Consider uploading reports for the commit f6d935b to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2602   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         285      285           
  Lines       15496    15496           
  Branches     1947     1947           
=======================================
  Hits        13314    13314           
  Misses       1799     1799           
  Partials      383      383

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galvana galvana requested a review from pattisdr February 15, 2023 18:23
pattisdr
pattisdr approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galvana changes look good to me - just some of the docstrings in the tests are incorrect now that delete is the default.

@galvana galvana merged commit bb3f4af into main Feb 15, 2023
@galvana galvana deleted the 2601-update-firebase-auth-to-delete-user branch February 15, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattisdr pattisdr pattisdr approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Firebase Auth to delete user instead of updating it
2 participants
@galvana @pattisdr