Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2464 - Update Logos for shipped connectors #2587

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

chriscalhoun1974
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 commented Feb 14, 2023

Closes #2464

Code Changes

  • Updated static recharge.svg files from Figma
  • Updated the max-width value of the Connector card container

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

Screenshot 2023-02-13 at 10 08 09 PM

@chriscalhoun1974 chriscalhoun1974 marked this pull request as draft February 14, 2023 03:03
@chriscalhoun1974 chriscalhoun1974 requested a review from a team February 14, 2023 03:13
@chriscalhoun1974 chriscalhoun1974 marked this pull request as ready for review February 14, 2023 03:13
@cypress
Copy link

cypress bot commented Feb 14, 2023

Passing run #56 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 4692f2e into a0a2984...
Project: fides Commit: 55938472dd ℹ️
Status: Passed Duration: 00:55 💡
Started: Feb 14, 2023 3:25 AM Ended: Feb 14, 2023 3:26 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 85.74% // Head: 85.73% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4692f2e) compared to base (eba67f0).
Patch has no changes to coverable lines.

❗ Current head 4692f2e differs from pull request most recent head 768862f. Consider uploading reports for the commit 768862f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2587      +/-   ##
==========================================
- Coverage   85.74%   85.73%   -0.01%     
==========================================
  Files         285      285              
  Lines       15477    15476       -1     
  Branches     1945     1945              
==========================================
- Hits        13270    13269       -1     
  Misses       1832     1832              
  Partials      375      375              
Impacted Files Coverage Δ
src/fides/lib/models/fides_user.py 100.00% <0.00%> (ø)
...fides/api/ops/service/connectors/saas_connector.py 67.54% <0.00%> (ø)
.../service/privacy_request/request_runner_service.py 74.29% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kelsey-Ethyca
Copy link
Contributor

Looks great!
Screen Shot 2023-02-14 at 1 25 20 PM

@chriscalhoun1974 chriscalhoun1974 merged commit 628f473 into main Feb 14, 2023
@chriscalhoun1974 chriscalhoun1974 deleted the 2464-update-logos-for-shipped-connectors branch February 14, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Logos for shipped connectors
2 participants