Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/custom-metadata: Refactor taxonomy to use a single form submission flow #2586

Merged

Conversation

ssangervasi
Copy link
Contributor

@ssangervasi ssangervasi commented Feb 14, 2023

Closes #2545

Code Changes

  • This is a large refactor to get taxonomy and custom fields working together. See description below and my line comments.

Steps to Confirm

  • Cypress tests!
  • From various taxonomy tabs
    • Assign custom fields
    • Single-select
      • Initial selection
      • Change selection
      • Clear selection
      • See value on reload
    • Multi-select
      • Initial selection
      • Change selection
      • Clear selection
      • See value on reload
  • Those steps, but from the "Describe system" tab

Pre-Merge Checklist

Description Of Changes

  • I'm tired. When I finish my self-review I'll check this box.

@cypress
Copy link

cypress bot commented Feb 14, 2023

Passing run #127 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge bbcf0a4 into 4bf8330...
Project: fides Commit: 623cc3966e ℹ️
Status: Passed Duration: 00:45 💡
Started: Feb 15, 2023 7:55 PM Ended: Feb 15, 2023 7:56 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 85.91% // Head: 85.91% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (bbcf0a4) compared to base (4bf8330).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2586      +/-   ##
==========================================
- Coverage   85.91%   85.91%   -0.01%     
==========================================
  Files         285      285              
  Lines       15496    15496              
  Branches     1947     1947              
==========================================
- Hits        13314    13313       -1     
  Misses       1799     1799              
- Partials      383      384       +1     
Impacted Files Coverage Δ
src/fides/api/ops/task/graph_task.py 90.90% <0.00%> (-0.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssangervasi ssangervasi force-pushed the ssangervasi/fides/2545/custom-metadata-ui-bug-roundup branch from 0d298d8 to 6988b9e Compare February 14, 2023 19:59
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whew, nice job!!

@ssangervasi ssangervasi force-pushed the ssangervasi/fides/2545/custom-metadata-ui-bug-roundup branch 2 times, most recently from 22b9e82 to 142dd69 Compare February 15, 2023 19:37
@ssangervasi ssangervasi force-pushed the ssangervasi/fides/2545/custom-metadata-ui-bug-roundup branch from 142dd69 to bbcf0a4 Compare February 15, 2023 19:39
@ssangervasi ssangervasi merged commit 368a407 into main Feb 15, 2023
@ssangervasi ssangervasi deleted the ssangervasi/fides/2545/custom-metadata-ui-bug-roundup branch February 15, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom metadata UI bug roundup
3 participants