Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User management UX fixes #2537

Merged
merged 9 commits into from
Feb 10, 2023
Merged

User management UX fixes #2537

merged 9 commits into from
Feb 10, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Feb 7, 2023

Closes #2296

Code Changes

  • Clean up admin UI README
  • Fix button stylings so when you hover they don't look unreadable
  • Refactor DeleteUserModal to use formik which allows us to do better validation
  • Refactor DeleteUserModal such that it isn't living inside the menu (which prevented tabbing from working)
  • Use common search bar component for user management page
  • Add cypress tests for deleting a user

Steps to Confirm

  • Poke around user management to make sure things look better
  • Delete a user

Pre-Merge Checklist

Description Of Changes

Deleting a user tabs properly now ☺️ and has better validation

Screen.Recording.2023-02-08.at.12.25.16.PM.mov

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 88.66% // Head: 88.66% // No change to project coverage 👍

Coverage data is based on head (450d2f2) compared to base (f0bc848).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         331      331           
  Lines       16099    16099           
  Branches     4469     4469           
=======================================
  Hits        14274    14274           
  Misses       1668     1668           
  Partials      157      157           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allisonking allisonking force-pushed the aking/2296/user-management-ux branch from 4a518cb to d67ae47 Compare February 8, 2023 17:23
@allisonking allisonking marked this pull request as ready for review February 8, 2023 19:11
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one small nit. I'm happy that we're slowly converting everything over to forkmik

scheming-evil-plan

@allisonking
Copy link
Contributor Author

privacy center check passed locally. the CI test seems to be failing across multiple branches, will need to look into it separately...

@allisonking allisonking merged commit 01425d5 into main Feb 10, 2023
@allisonking allisonking deleted the aking/2296/user-management-ux branch February 10, 2023 16:20
allisonking added a commit that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User management form UX improvements
2 participants