Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where legacy dataset has meta: null #2524

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Feb 6, 2023

Closes #2509

Code Changes

  • Update migration upgrade script

Steps to Confirm

n/a

Pre-Merge Checklist

Description Of Changes

The fix in #2510 isn't quite right - it's also possible for dataset.get("meta", {}) to return None if someone defines a Dataset with a meta key but keeps it null. This can be hard to do locally but happens in practice.

Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @NevilleS

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 88.47% // Head: 88.45% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (f46ef8e) compared to base (b7c69d3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2524      +/-   ##
==========================================
- Coverage   88.47%   88.45%   -0.02%     
==========================================
  Files         328      328              
  Lines       15959    15959              
  Branches     4433     4433              
==========================================
- Hits        14119    14117       -2     
- Misses       1687     1688       +1     
- Partials      153      154       +1     
Impacted Files Coverage Δ
src/fides/api/ctl/utils/errors.py 88.23% <0.00%> (-5.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seanpreston seanpreston merged commit 2d26905 into main Feb 6, 2023
@seanpreston seanpreston deleted the 2509-ns-fix-migration branch February 6, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database migration fails when upgrading to 2.6.1
4 participants