Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Admin UI to show all action types (access, erasure, consent, update) #2523

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Feb 6, 2023

Code Changes

  • Update frontend ActionType to include all potential action type values

Steps to Confirm

  • Edit src/fides/data/test_env/privacy_center_config/config.json: change executable: true for the Data Sales or Sharing consent option
  • Run nox -s fides_env(test)
  • Submit access, erasure, and consent requests from the privacy center (for consent, ensure you opt-out of the Data Sales or Sharing option as it is the executable one)
  • Confirm that the different Privacy Requests show each type: Access, Erasure, Consent:

image

(screenshot showing this in action using `fides_env(test)` locally)

Pre-Merge Checklist

Description Of Changes

The frontend type for ActionType has lagged behind the valid values from the Python model - this updates the Admin UI to support the "consent" and "update" types.

See the Python enum that defines these: https://github.com/ethyca/fides/blob/main/src/fides/api/ops/models/policy.py#L40

The frontend type for `ActionType` has lagged behind the valid values from the Python model - this updates the Admin UI to support the "consent" and "update" types
@NevilleS NevilleS force-pushed the ns-update-admin-ui-action-types branch from 013f327 to 29d21bc Compare February 6, 2023 19:43
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked exactly as described :shipit:

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 88.45% // Head: 88.45% // No change to project coverage 👍

Coverage data is based on head (29d21bc) compared to base (37b7994).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2523   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         328      328           
  Lines       15959    15959           
  Branches     4433     4433           
=======================================
  Hits        14117    14117           
  Misses       1688     1688           
  Partials      154      154           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NevilleS NevilleS merged commit b7c69d3 into main Feb 6, 2023
@NevilleS NevilleS deleted the ns-update-admin-ui-action-types branch February 6, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants