Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate paths #2502

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Consolidate paths #2502

merged 6 commits into from
Feb 7, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Feb 3, 2023

A more thorough fix for #2491

Code Changes

  • Removes the local file map check which doesn't need to exist anymore since the package file map check can handle both cases (installed at src/fides or installed at /usr/local/lib/python/site-packages

Steps to Confirm

The hotfix in #2500 fixes things, but not if you have your volume mount active. This should fix it whether or not you have your volume mount around.

To repro in the dev environment

  • Have a local build via npm run prod-export
  • nox -s "fides_env(dev)"
  • Navigate to localhost:8080/dataset. it should load now!

To repro in the prod environment

  • Have a local build via npm run prod-export
  • nox -s "fides_env(test)"
  • Navigate to localhost:8080/dataset. it should load now!

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

src/fides/api/main.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 88.47% // Head: 88.44% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (57882ed) compared to base (0fa8359).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2502      +/-   ##
==========================================
- Coverage   88.47%   88.44%   -0.03%     
==========================================
  Files         328      328              
  Lines       15959    15954       -5     
  Branches     4433     4431       -2     
==========================================
- Hits        14119    14110       -9     
- Misses       1687     1689       +2     
- Partials      153      155       +2     
Impacted Files Coverage Δ
src/fides/api/ctl/ui.py 81.69% <100.00%> (-3.45%) ⬇️
src/fides/api/main.py 86.75% <100.00%> (-0.18%) ⬇️
src/fides/api/ctl/utils/errors.py 88.23% <0.00%> (-5.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allisonking allisonking marked this pull request as ready for review February 6, 2023 16:47
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review. It works great! 🚀

@allisonking allisonking merged commit 2205677 into main Feb 7, 2023
@allisonking allisonking deleted the aking/hotfix-refresh-page branch February 7, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants