-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate paths #2502
Consolidate paths #2502
Conversation
Codecov ReportBase: 88.47% // Head: 88.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2502 +/- ##
==========================================
- Coverage 88.47% 88.44% -0.03%
==========================================
Files 328 328
Lines 15959 15954 -5
Branches 4433 4431 -2
==========================================
- Hits 14119 14110 -9
- Misses 1687 1689 +2
- Partials 153 155 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review. It works great! 🚀
A more thorough fix for #2491
Code Changes
src/fides
or installed at/usr/local/lib/python/site-packages
Steps to Confirm
The hotfix in #2500 fixes things, but not if you have your volume mount active. This should fix it whether or not you have your volume mount around.
To repro in the dev environment
npm run prod-export
nox -s "fides_env(dev)"
localhost:8080/dataset
. it should load now!To repro in the prod environment
npm run prod-export
nox -s "fides_env(test)"
localhost:8080/dataset
. it should load now!Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats