Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klaviyo Connector #2501

Merged
merged 12 commits into from
Apr 17, 2023
Merged

Klaviyo Connector #2501

merged 12 commits into from
Apr 17, 2023

Conversation

ctvivek
Copy link
Contributor

@ctvivek ctvivek commented Feb 3, 2023

Closes #1941

Code Changes

NEW SaaS Connector Klaviyo for access and erasure

Steps to Confirm

  • Add/configure the Klaviyo connector in UI
  • Verify Klaviyo config and icon UI looks good
  • Add customer data using Klaviyo UI (no api to add sales)
  • Create an Access DSR with the new Klaviyo customer email
  • Verify email sent by fides with customer data is correct
  • Create an Delete DSR with the new Klaviyo customer email
  • Verify the customer data is now deleted in Klaviyo

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

SaaS Connector Checklist

  • Spec doc link
  • Vault Creds
  • Postman Collection
  • SaaS Config And Dataset
  • Access and Erasure Tests Passing
  • Icon

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (4a864b2) 87.39% compared to head (166b6f2) 87.41%.

❗ Current head 166b6f2 differs from pull request most recent head 8d900cc. Consider uploading reports for the commit 8d900cc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
+ Coverage   87.39%   87.41%   +0.02%     
==========================================
  Files         306      306              
  Lines       17598    17540      -58     
  Branches     2270     2255      -15     
==========================================
- Hits        15379    15333      -46     
+ Misses       1801     1793       -8     
+ Partials      418      414       -4     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ctvivek
Copy link
Contributor Author

ctvivek commented Feb 28, 2023

Screenshot from 2023-02-28 21-23-44

@ctvivek
Copy link
Contributor Author

ctvivek commented Feb 28, 2023

Screenshot from 2023-02-28 21-25-06

@ctvivek
Copy link
Contributor Author

ctvivek commented Feb 28, 2023

Screenshot from 2023-02-28 21-31-33

@ctvivek
Copy link
Contributor Author

ctvivek commented Feb 28, 2023

Screenshot from 2023-03-01 00-09-17

@Kelsey-Ethyca Kelsey-Ethyca changed the title klaviyo test Klaviyo Connector Mar 13, 2023
@cypress
Copy link

cypress bot commented Apr 13, 2023

Passing run #1342 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 36f62bd into 8b988ac...
Project: fides Commit: 3a639bc2bb ℹ️
Status: Passed Duration: 00:50 💡
Started: Apr 13, 2023 10:16 PM Ended: Apr 13, 2023 10:17 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@galvana galvana self-requested a review April 17, 2023 23:53
@galvana galvana merged commit ad1972c into main Apr 17, 2023
@galvana galvana deleted the klaviyo-access-vivek branch April 17, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Klaviyo
4 participants