Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make policy_key optional for consent #2479

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Feb 2, 2023

Policy key can be optional in privacy center config.json

Code Changes

  • Just a TS fix so there's no breaking change in the privacy center

Steps to Confirm

  • Remove the policy_key from the consent block of the config.json
  • Run npm run build. it should build 👌

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick work here @allisonking! Tested and it works fine.

On the backend we currently have it so if no policy_key is passed in, we try to revert to the default consent policy for now.

@allisonking allisonking marked this pull request as ready for review February 2, 2023 16:07
@adamsachs adamsachs mentioned this pull request Feb 2, 2023
6 tasks
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 73.12% // Head: 88.45% // Increases project coverage by +15.32% 🎉

Coverage data is based on head (4bc8f43) compared to base (d00b2d6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2479       +/-   ##
===========================================
+ Coverage   73.12%   88.45%   +15.32%     
===========================================
  Files         327      327               
  Lines       15957    15957               
  Branches     4431     4431               
===========================================
+ Hits        11669    14115     +2446     
+ Misses       4217     1688     -2529     
- Partials       71      154       +83     
Impacted Files Coverage Δ
src/fides/api/ops/schemas/privacy_request.py 100.00% <0.00%> (+0.57%) ⬆️
src/fides/api/ctl/database/crud.py 71.55% <0.00%> (+0.91%) ⬆️
src/fides/api/ops/graph/graph_differences.py 98.57% <0.00%> (+1.42%) ⬆️
...e/masking/strategy/masking_strategy_aes_encrypt.py 92.72% <0.00%> (+1.81%) ⬆️
src/fides/api/ops/common_exceptions.py 98.01% <0.00%> (+1.98%) ⬆️
...s/api/ops/service/connectors/fides/fides_client.py 85.85% <0.00%> (+2.02%) ⬆️
...fides/api/ops/service/connectors/base_connector.py 97.36% <0.00%> (+2.63%) ⬆️
src/fides/api/ops/util/encryption/secrets_util.py 97.05% <0.00%> (+2.94%) ⬆️
src/fides/api/ops/api/deps.py 96.15% <0.00%> (+3.84%) ⬆️
src/fides/api/ctl/routes/health.py 87.50% <0.00%> (+4.16%) ⬆️
... and 114 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allisonking allisonking merged commit 82330c8 into main Feb 2, 2023
@allisonking allisonking deleted the aking/fix-pc-config-type branch February 2, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants