Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI git permissions #2441

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Fix CI git permissions #2441

merged 4 commits into from
Jan 31, 2023

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Jan 31, 2023

Closes #2440

Code Changes

  • Add a line to the CI workflow that sets git directory permissions

Steps to Confirm

  • pytest(ctl-not-external) checks pass

Pre-Merge Checklist

Description Of Changes

GitHub Actions Issue

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 82.48% // Head: 88.55% // Increases project coverage by +6.07% 🎉

Coverage data is based on head (e6445c3) compared to base (9276432).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2441      +/-   ##
==========================================
+ Coverage   82.48%   88.55%   +6.07%     
==========================================
  Files         327      327              
  Lines       15714    15714              
  Branches     4348     4348              
==========================================
+ Hits        12961    13915     +954     
+ Misses       2642     1644     -998     
- Partials      111      155      +44     
Impacted Files Coverage Δ
src/fides/api/ops/models/policy.py 93.23% <0.00%> (+1.12%) ⬆️
src/fides/core/config/__init__.py 91.86% <0.00%> (+1.16%) ⬆️
src/fides/lib/db/base_class.py 89.28% <0.00%> (+1.42%) ⬆️
src/fides/api/ops/schemas/dataset.py 100.00% <0.00%> (+1.49%) ⬆️
.../ops/api/v1/endpoints/user_permission_endpoints.py 95.91% <0.00%> (+2.04%) ⬆️
src/fides/api/ctl/routes/health.py 87.50% <0.00%> (+2.08%) ⬆️
src/fides/cli/options.py 94.87% <0.00%> (+2.56%) ⬆️
src/fides/cli/commands/generate.py 86.56% <0.00%> (+2.98%) ⬆️
src/fides/api/main.py 86.20% <0.00%> (+3.44%) ⬆️
src/fides/cli/commands/scan.py 88.67% <0.00%> (+5.66%) ⬆️
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ThomasLaPiana
Copy link
Contributor Author

CI Checks all passed, executive merge to unstick other PRs

@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review January 31, 2023 05:24
@ThomasLaPiana ThomasLaPiana merged commit 9e9d156 into main Jan 31, 2023
@ThomasLaPiana ThomasLaPiana deleted the ThomasLaPiana-fix-git-ci branch January 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git permissions error causing failing pipelines
1 participant