Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include latest tag on privacy-center and sample-app images #2407

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jan 27, 2023

Closes #2301

Code Changes

  • Update dev to latest on nox -s "push(prod)"

Steps to Confirm

  • validated manually, ci checks can be tricky sometimes

Pre-Merge Checklist

Description Of Changes

nox -s "push(dev)" runs on every push to main and releases meaning we were just duplicating the dev tags!

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 88.55% // Head: 88.55% // No change to project coverage 👍

Coverage data is based on head (b10999f) compared to base (e8544d4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2407   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files         327      327           
  Lines       15714    15714           
  Branches     4348     4348           
=======================================
  Hits        13915    13915           
  Misses       1644     1644           
  Partials      155      155           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SteveDMurphy SteveDMurphy marked this pull request as ready for review January 27, 2023 16:04
@SteveDMurphy SteveDMurphy merged commit 1b9a2c0 into main Feb 2, 2023
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-2301-latest-tags branch February 2, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing latest image tags on privacy center and sample app
2 participants