pc/modals: Disable submit buttons on when Formik isSubmitting #2401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2219
Code Changes
isSubmitting
on all of these forms to prevent repeat clicksisLoading
loading state which is redundant and not implemented correctly.Steps to Confirm
/verify
call per submit.Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
I couldn't actually reproduce the error banner from the ticket - repeat clicks would send multiple requests but they would respond 200. I tried with and without
require_manual_request_approval
enabled infides.test_env.toml
.But either way there's no reason to submit multiple. These modals should all have smart submit buttons.
My screen recorder shows my fast clicks as that animated circle:
https://user-images.githubusercontent.com/2236777/214980028-3bc9b69d-f1ec-403a-8683-de30d783f412.mp4
Also added the loading state: