Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display policy key on request details page #2395

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Display policy key on request details page #2395

merged 5 commits into from
Jan 30, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

Closes #2288

Code Changes

  • Display policy key on request details page

Steps to Confirm

  • Run fides and navigate to a request details page
  • ensure the policy key is displayed

Pre-Merge Checklist

Description Of Changes

Simple change to display the policy key on the request details page.

Screenshot 2023-01-26 at 15 00 32

@TheAndrewJackson TheAndrewJackson self-assigned this Jan 26, 2023
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review January 26, 2023 20:20
allisonking
allisonking approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@TheAndrewJackson TheAndrewJackson merged commit f944aa9 into main Jan 30, 2023
@TheAndrewJackson TheAndrewJackson deleted the bugfix_2288_policy_key_on_request_details_page branch January 30, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

@seanpreston seanpreston Awaiting requested review from seanpreston

@NevilleS NevilleS Awaiting requested review from NevilleS

Assignees

@TheAndrewJackson TheAndrewJackson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request Details page should include the policy key
2 participants
@TheAndrewJackson @allisonking