Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc/modals: PhoneInput component with bundled flag icons #2378

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

ssangervasi
Copy link
Contributor

Closes #2361

Code Changes

  • Extracted the duplicate PhoneInput code to its own file
  • Import and pass the flag icons directly to the JS.

Steps to Confirm

  • Toggle phone country => no requests in network tab to other domains for SVGs.

Pre-Merge Checklist

Description Of Changes

Once you click on a card, the input modal shows up. At that time the chunk that includes the icons loads in:

Screen Shot 2023-01-25 at 16 43 27

And then you can see the SVG src is right in the page (no network request for icon):

Screen Shot 2023-01-25 at 16 34 49

Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎏 👍

@ssangervasi ssangervasi force-pushed the ssangervasi/fides/2361/bundle-phone-icons branch from 5a62278 to c888ccd Compare January 26, 2023 21:53
@ssangervasi ssangervasi merged commit 159b235 into main Jan 26, 2023
@ssangervasi ssangervasi deleted the ssangervasi/fides/2361/bundle-phone-icons branch January 26, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serve the flag icons from Fides/privacy center
2 participants