-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a scope to allow resetting other users' passwords #2373
Conversation
A user should always be able to change their own password
src/fides/api/ctl/migrations/versions/7e218e880eaf_remove_user_reset_password_scope.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @allisonking — just one minor comment on the docstring :)
Codecov ReportBase: 88.55% // Head: 88.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2373 +/- ##
=======================================
Coverage 88.55% 88.56%
=======================================
Files 327 327
Lines 15714 15726 +12
Branches 4348 4351 +3
=======================================
+ Hits 13915 13927 +12
Misses 1644 1644
Partials 155 155
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Going to merge, as the failing pylint test is unrelated to this PR |
Closes #2208
Closes #2007
Code Changes
user:reset-password
scope in favor of loosening up the endpoint to just always allow users to change their own passwords (as opposed to only allowing users to change their passwords in addition to needing this scope)user:reset-password
from every useruser:password-reset
(I know, the name is confusing if the old scope still exists!! I had some trouble with naming in this PR.password-reset
/reset-password
just seems like the right name for this action!) which allows the user with this scope to reset passwords without knowing the old one (including other users'!)/user/{user_id}/force-reset-password
to allow resetting a password without knowing the old one which is scoped onuser:password-reset
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats