-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2234 & 2235/configure storage destination #2358
Conversation
); | ||
if ( | ||
href === "/privacy-requests/configure" && | ||
!features.flags.privacyRequestsConfiguration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This toggling of certain routes based on feature flags should be done from the nav config helpers themselves instead of within component markup. Check out configureNavGroups and its unit tests -- it already takes in some features to decide what should be shown.
@@ -353,6 +353,32 @@ export const privacyRequestApi = createApi({ | |||
}), | |||
invalidatesTags: ["Notification"], | |||
}), | |||
getStorageDetails: build.query<any, any>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no does this whole file use any
for its query params/returns? I'd expect the models to be generated by openapi.
clients/admin-ui/src/features/privacy-requests/privacy-requests.slice.ts
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/privacy-requests/configuration/StorageConfiguration.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/privacy-requests/configuration/StorageConfiguration.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want some cypress tests, too.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2358 +/- ##
=======================================
Coverage ? 88.55%
=======================================
Files ? 327
Lines ? 15714
Branches ? 4348
=======================================
Hits ? 13915
Misses ? 1644
Partials ? 155 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closes #2234
Closes #2235
NOTE:
Note: The onClick behavior for the messaging box won't do anything yet until the subsequent issue is complete. This feature is flagged.
TODO:
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats