Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fideslang version #2343

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jan 24, 2023

Closes #514

Code Changes

  • Update fideslang to 1.3.3

Steps to Confirm

  • Run fides with nox -s dev
  • Manually create a system through postman.
    • Add privacy declaration(s) with only data_use, data_subjects, and data_categories

Here is the payload I used to test this change

{
    "name": "My Main Postgres DB",
    "fides_key": "hello_world",
    "system_type": "postgres",
    "key": "postgres_db_1",
    "connection_type": "postgres",
    "access": "write",
    "privacy_declarations": [
        {
            "data_use": "testing123",
            "data_subjects": [],
            "data_categories": []
        }
    ]
}

Pre-Merge Checklist

Description Of Changes

Update fideslang to 1.3.3. This will make PrivacyDeclation.name optional. It allows privacy declarations to only need the use, categories, and subjects which matches the data model described in #514

Dockerfile Show resolved Hide resolved
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review January 24, 2023 16:36
@TheAndrewJackson TheAndrewJackson requested a review from a team January 24, 2023 16:41
@TheAndrewJackson TheAndrewJackson merged commit c4c6ed9 into main Jan 24, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson_514_privacy_declartion_update branch January 24, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants