Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2200 - Home screen header scaling and responsiveness issues #2277

Merged
merged 5 commits into from
Jan 20, 2023
Merged

2200 - Home screen header scaling and responsiveness issues #2277

merged 5 commits into from
Jan 20, 2023

Conversation

chriscalhoun1974
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 commented Jan 19, 2023 •
edited
Loading

Closes #2200

Code Changes

  • Updated HomeBanner and HomeLayout components

Steps to Confirm

  1. Open a Chrome browser tab
  2. Navigate to http://localhost:3000
  3. Login with fidestest credentials
  4. Right click and select the Inspect menu item
  5. Within the Chrome dev tools, click the Toggle device toolbar icon
  6. Update the Dimension Responsiveness values (i.e. 1920 x 1080)

Screenshot 2023-01-20 at 10 29 54 AM

Pre-Merge Checklist

Description Of Changes

  • Ensured the HomeBanner and HomeLayout components to be responsive when viewed at lower resolutions.

@chriscalhoun1974 chriscalhoun1974 marked this pull request as draft January 19, 2023 15:18
@chriscalhoun1974 chriscalhoun1974 marked this pull request as ready for review January 19, 2023 15:23
@chriscalhoun1974 chriscalhoun1974 marked this pull request as draft January 19, 2023 15:28
@chriscalhoun1974 chriscalhoun1974 marked this pull request as ready for review January 19, 2023 15:51
@chriscalhoun1974 chriscalhoun1974 mentioned this pull request Jan 19, 2023
Closed
simon-keane
simon-keane approved these changes Jan 20, 2023
View reviewed changes
Copy link

@simon-keane simon-keane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side @chriscalhoun1974

@chriscalhoun1974 chriscalhoun1974 merged commit 466ad97 into main Jan 20, 2023
@chriscalhoun1974 chriscalhoun1974 deleted the 2200-home-screen-header-scaling-and-responsiveness-issues branch January 20, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-keane simon-keane simon-keane approved these changes

@ssangervasi ssangervasi Awaiting requested review from ssangervasi

@LKCSmith LKCSmith Awaiting requested review from LKCSmith

@Kelsey-Ethyca Kelsey-Ethyca Awaiting requested review from Kelsey-Ethyca

Assignees
No one assigned
Labels
Fides NUX Improvements UI Work related to UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home screen header scaling and responsiveness issues
2 participants
@chriscalhoun1974 @simon-keane