Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unclear config warning #2266

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Remove unclear config warning #2266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56d0189
Remove unclear config warning
ThomasLaPiana Jan 18, 2023
df91a84
refactor: move a logging statement to after the config is loaded
ThomasLaPiana Jan 18, 2023
a320437
docs: updated changelog
ThomasLaPiana Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ The types of changes are:
* No longer use `react-feature-flags` library.
* Can have descriptions. [#2243](https://github.com/ethyca/fides/pull/2243)
* Made privacy declarations optional when adding systems manually - [#2173](https://github.com/ethyca/fides/pull/2173)
* Removed an unclear logging message. [#2266](https://github.com/ethyca/fides/pull/2266)
* Dynamic imports of custom overrides and SaaS test fixtures [#2169](https://github.com/ethyca/fides/pull/2169)
* Added `AuthenticatedClient` to custom request override interface [#2171](https://github.com/ethyca/fides/pull/2171)

Expand Down
5 changes: 2 additions & 3 deletions src/fides/core/config/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,15 +171,14 @@ def get_config(config_path_override: str = "", verbose: bool = False) -> FidesCo

env_config_path = getenv(DEFAULT_CONFIG_PATH_ENV_VAR)
config_path = config_path_override or env_config_path or DEFAULT_CONFIG_PATH
if verbose:
print(f"Loading config from: {config_path}")

try:
settings = toml.load(config_path)
config = build_config(config_dict=settings)
print(f"Loaded config from: {config_path}")
return config
except FileNotFoundError:
print("No config file found.")
pass
except IOError:
echo_red(f"Error reading config file: {config_path}")

Expand Down