-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pc/consent: Fides.meta integration function #2217
pc/consent: Fides.meta integration function #2217
Conversation
Code Climate has analyzed commit b07547c and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
947aeee
to
ea29343
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssangervasi This makes sense to me in general. Since we are just shipping the defaults, do you think it makes sense to create cookie keys that are even more explicit? Something like meta_tracking
and shopify_tracking
since we can have multiple keys on a data use?
I know it's a bit repetitive, but the very obvious naming might make it easier for someone unfamiliar with the project to parse.
b07547c
to
38509b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Blessings on your whack-a-mole hunt
Closes #2160
Doc: https://ethyca.atlassian.net/wiki/spaces/EN/pages/2583789680/Facebook+fides-consent.js
Code Changes
fbq
shimming process that FB just wants you to paste into pages. Somehow worse than GTM.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
It's been tough to integrate with Meta because:
fbq
doesn't have an API for reading what its state is, so you just have to hope a lack of error messages means something happenedThat said, the options I've provided for this function cover the cases that were documented, leaning towards privacy-by-default instead of give-away-everything by default.