Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for twilio email (sendgrid) dispatch #2154

Merged
merged 7 commits into from
Jan 11, 2023

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Jan 6, 2023

Closes #1975

Code Changes

  • Adds dispatcher for Twilio Email
  • Adds sendgrid client to requirements
  • Updates model for Twilio Email to include additional details needed in config

Note- this ticket does not include support for fides templates through sendgrid.

Steps to Confirm

  • In config:
FIDES__EXECUTION__SUBJECT_IDENTITY_VERIFICATION_REQUIRED=true
FIDES__NOTIFICATIONS__NOTIFICATION_SERVICE_TYPE="twilio_email"
FIDES__NOTIFICATIONS__SEND_REQUEST_COMPLETION_NOTIFICATION=true
FIDES__NOTIFICATIONS__SEND_REQUEST_RECEIPT_NOTIFICATION=true
FIDES__NOTIFICATIONS__SEND_REQUEST_REVIEW_NOTIFICATION=true
  • Set up a Sendgrid test acct
  • Use postman to add a new Twilio Email config:
{
    "key": "twilio_email_key",
    "name": "twilio_email",
    "service_type": "twilio_email",
    "details": {
    "twilio_email_from": "[email protected]"
    }
}
  • Use postman to add Twilio Email secrets:
{
    "twilio_api_key": "your-api-key"
}
  • Submit privacy request and confirm emails are sent

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@adamsachs adamsachs self-requested a review January 6, 2023 18:11
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this all looks really good! was able to test successfully (at least to the point of getting an initial verification code) to my email. the updates look very clean and were easy to follow!

i just have a few minor polish points with error handling - let me know what you think.

@eastandwestwind eastandwestwind force-pushed the 1975-sendgrid-dispatcher branch from 0547915 to e870598 Compare January 10, 2023 19:18
@eastandwestwind eastandwestwind force-pushed the 1975-sendgrid-dispatcher branch from e870598 to 2a1c2ca Compare January 10, 2023 19:49
@eastandwestwind eastandwestwind merged commit cc00448 into main Jan 11, 2023
@eastandwestwind eastandwestwind deleted the 1975-sendgrid-dispatcher branch January 11, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm SendGrid works with current emails
2 participants