Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove other add system flow #2132

Merged
merged 5 commits into from
Jan 6, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jan 4, 2023

Closes https://github.com/ethyca/fidesplus/issues/472

Code Changes

  • Removes the "Create new system" button as described in https://github.com/ethyca/fidesplus/issues/472. This also removes the yaml upload form, which was the original problem.
  • Also removes the relevant pages and changes the editing page from /new/configure to just /configure since we no longer have a /new page (it's just /add-systems now)
  • Restores systems cypress tests

Steps to Confirm

  • Clicking "Add systems" and then "View systems" in the side nav should no longer give you a button to add systems. All systems should be added via the "Add systems" button instead.

Pre-Merge Checklist

Description of Changes

Screen.Recording.2023-01-04.at.2.50.09.PM.mov

@allisonking allisonking marked this pull request as ready for review January 4, 2023 19:59
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💥

@allisonking allisonking merged commit 8e213bb into main Jan 6, 2023
@allisonking allisonking deleted the aking/fidesplus-472/remove-system-yaml branch January 6, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants