Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll classification results for datasets #2123

Merged
merged 6 commits into from
Jan 5, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jan 3, 2023

Closes https://github.com/ethyca/fidesplus/issues/402

Code Changes

  • Pull polling code into a common hook
  • Use hook in dataset classification flow

Steps to Confirm

  • Make sure data flow classification still works by using the data flow scanner and waiting for classification results.
  • Make sure dataset classification still works by going to localhost:3000/dataset with the fidesplus backend. Create a dataset by connecting to a database (i.e. postgresql://postgres:[email protected]:5432/fides). Wait for classification without refreshing the page. This can take ~15 minutes. If you open the network tab, you should see it checking the classification results every 3 seconds

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking marked this pull request as ready for review January 3, 2023 23:29
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@allisonking allisonking merged commit 1af7a32 into main Jan 5, 2023
@allisonking allisonking deleted the aking/fidesplus-402/dataset-classify-poll branch January 5, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants