Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use verification ttl property when setting in cache #2105

Merged
merged 2 commits into from
Dec 23, 2022
Merged

use verification ttl property when setting in cache #2105

merged 2 commits into from
Dec 23, 2022

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Dec 22, 2022 •
edited
Loading

Closes #2104

Code Changes

  • use redis.identity_verification_code_ttl_seconds config property when setting the verification code in the cache
  • provide some test coverage

Steps to Confirm

look at issue description

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@adamsachs adamsachs self-assigned this Dec 22, 2022
@eastandwestwind eastandwestwind mentioned this pull request Dec 22, 2022
Merged
16 tasks
eastandwestwind
eastandwestwind approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Manually tested with a 1 sec ttl, and confirmed that a warning modal popped up on the PC, reading An error occurred while verifying your identity Identification code expired for pri_aa9ad896-8d64-4918-95df-ac8f61fa7019.

eastandwestwind
eastandwestwind reviewed Dec 23, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@adamsachs adamsachs force-pushed the fix-verification-cache-expire branch from 9d875ed to ab3ce70 Compare December 23, 2022 14:34
@adamsachs adamsachs merged commit 1cb7c62 into main Dec 23, 2022
@adamsachs adamsachs deleted the fix-verification-cache-expire branch December 23, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees

@adamsachs adamsachs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the redis.identity_verification_code_ttl_seconds config property is not being respected
2 participants
@adamsachs @eastandwestwind