-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test collection workflow pre-step #2098
Conversation
the above CI check shows that when the collection passes, everything runs as usual. I'll now purposefully break the collection to confirm that the tests wont run |
the above CI run should break and prevent pytests from running edit: note that they were skipped as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is good like it is, just a question. Would it be worth it to move the collection test to the docker build since that step is what takes longest to run and the pytest steps won't run without build?
Oh, that makes way more sense! Ok, i'll make |
The skipped and failed tests here look to me to be github network related and not PR related. Restarting to see if that fixes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure again looks unrelated to the PR
Closes #2033
Code Changes
Collect-Tests
workflow step via theBuild
stepSteps to Confirm
nox -s collect_tests
locally (first run will take awhile as it caches the installations)Collect-Tests
job runs as expected and the output looks correctCollect-Tests
doesn't pass, the pytest jobs don't get runPre-Merge Checklist
Relevant Follow-Up Issues CreatedCHANGELOG.md
Description Of Changes
This is meant to be a straightforward PR that will serve to both