-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user creation as root #2082
Conversation
@sanders41 I believe I broke this with the |
…nd it when instantiating ConnectionConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, and i verified that things are working now on nox -s test_env
just to be sure. thanks for the updated PR description to explain the changes!
Co-authored-by: Sean Preston <[email protected]>
Closes #2077
Code Changes
Steps to Confirm
nox -s dev
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This regression was caused by the removal of the
fideslib
references from our codebase.fideslib
was designed to have a common override pattern (with safe backstop) for theverify_oauth_client
API dependency — which is not being overridden correctly now that the code is in the main codebase. This PR switches out the version of that method designed to be overloaded with the current method in use by the rest of the codebase.