Do not always create a fides.toml
by default
#2023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1661
Code Changes
check_and_update_analytics_config
whenfides init
is runSteps to Confirm
fides
, confirm no file was written and no.fides
dir existsfides init
and confirm that the flow works, as well as prompting about user analyticsPre-Merge Checklist
CHANGELOG.md
Description Of Changes
The side-effect of having the
fides.toml
always be created whether it exists or not is a bit redundant and potentially error-prone (see the attached issue for more discussion). As such, the config file should only be created when a user specifically runs thefides init
commandDue to this change though, we also needed to update how
analytics_opt_out
is handled, given that before we always expected the user to have a file-based configuration file to update. The behaviour is now that we assume analytics is false if there is no config file, but will prompt the user for it when they runfides init
. This means we defaulting toopt-out
and are no longer prompting the user every time they use the CLI to update this. I think this is no longer a major issue, as we should be relying more heavily on theuser registration
flow for valuable usage analytics.