Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data flow scanner health check #1973

Merged
merged 9 commits into from
Dec 2, 2022
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Dec 2, 2022

Closes #1843

Code Changes

  • Update autogenerated typescript types
  • Render the data flow scanner button as disabled if data flow scanning is not enabled
  • Show a health indicator based on if the cluster is healthy
  • Cypress tests

Steps to Confirm

  • Start up the fidesplus backend with the system scanner enabled and connected
  • Visit the /add-systems page and confirm that the data flow scanner button is clickable and has a green healthy indicator

image

  • Start up the fidesplus backend with the system scanner disabled
  • Visit the /add-systems page and confirm that the data flow scanner button is disabled and there is no health indicator

image

  • Start up the fidesplus backend with the system scanner enabled but not configured properly (i.e. give yourself an invalid pixie key)
  • Visit the /add-systems page and confirm that the data flow scanner button is disabled with a red unhealthy indicator

image

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking force-pushed the aking/1843/data-flow-health-check branch 2 times, most recently from 3799fd0 to d8261d1 Compare December 2, 2022 15:25
@allisonking allisonking force-pushed the aking/1843/data-flow-health-check branch from d8261d1 to 58c37d3 Compare December 2, 2022 15:30
@allisonking allisonking marked this pull request as ready for review December 2, 2022 17:50
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished my initial code review. I like these changes. Just one small nit.

I'm going to run the code locally now and take a look at everything.

Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit: The mocked out payload can be updated later if it's a hassle to fix that now

@allisonking allisonking merged commit 765124e into main Dec 2, 2022
@allisonking allisonking deleted the aking/1843/data-flow-health-check branch December 2, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Healthcheck UI on the /config-wizard flow
2 participants