Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc/consent: Restructure consent src dir to make modle/browser distinction clearer #1904

Merged

Conversation

ssangervasi
Copy link
Contributor

Start of #1801

Code Changes

  • Move src/index.ts to src/fides-consent.ts to make it clearer it becomes dist/fides-consent.js
  • Move src/cookie.ts to src/lib/cookie.ts
  • Add src/lib/index.ts and use it as the root of the module build, so that if we want to add other code that isn't specifically for cookies (like a Shopify helper) we can have multiple files.

Steps to Confirm

  • Nothing should change 🙂

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@ssangervasi ssangervasi merged commit 754c93f into main Nov 30, 2022
@ssangervasi ssangervasi deleted the ssangervasi/fides-1801/consent-script-beyond-cookie branch November 30, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants