-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dsr error handling configure alerts #1895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that-have-errored
…that-have-errored
…' into 1203-individually-select-and-reprocess-DSRs-that-have-errored
…that-have-errored
…ividually-select-and-reprocess-DSRs-that-have-errored
…ing the checkbox column header
This was referenced Nov 30, 2022
@sanders41 The validation issue you identified has been resolved now. |
sanders41
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from a functionality standpoint.
@Roger-Ethyca @Kelsey-Ethyca Ready for you to QA. Let @sanders41 or I know if you have any questions. Thank you! |
Kelsey-Ethyca
approved these changes
Dec 14, 2022
I have removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1218 #1491 #1492
Code Changes
configureAlertsFlag
to theflags.json
fileMore > Configure alerts
to the Privacy Requests landing pageMore > Configure alerts
menu item, Configure alerts and notifications drawer is displayed which allows a user to configure a list of email recipients, to be notified immediately, and enter threshold number of DSR processing errors.ON
and clicked the SAVE button, there is a polling process for every 15 seconds which invokes the API endpoint (api/v1/privacy-request?include_identities=true&status=error
). If there are new DSR processing errors in which the total is greater than or equal to the DSR processing errors threshold configured, a toast error notification is displayed with the following text: DSR automation has failed for [X] privacy request(s). Please review the event log for further details.NOTE All of the above coding changes are behind the release flag called
configureAlertsFlag
which is located in theflags.json
file. By default, theisActive
property is turned tofalse
. For testing purposes, you can edit this value totrue
.Steps to Confirm
More > Configure
alerts menu item located in the upper right hand corner.ON
, accept the default threshold value, and click the Save button.OFF
via clicking theMore > Configure
alerts menu item located in the upper right hand corner.Pre-Merge Checklist
CHANGELOG.md
Screen Shots